On Mon, Aug 12, 2013 at 10:41:43AM -0400, Alon Levy wrote: > > On Mon, Aug 12, 2013 at 09:08:36AM -0400, Yonit Halperin wrote: > > > Hi, > > > > > > You forgot to add spice_server_utils.h :) > > > > There's a spice-common/common/bitops.h file, maybe it makes sense to have > > these functions there? > > But now that we have spice-common as a submodule, and since these functions aren't used by the client, does it really? Since none of these files are big, I prefer to group generic related functions in the same file even if they are only used by server or client rather than having 2 small files. With that said, if you prefer to have them in their own file in spice-server, that's fine with me. Christophe
Attachment:
pgpZPq2hsxZmy.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel