Re: [PATCH 1/3] display/driver: DrvDeleteDeviceBitmap: log if pdev disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack
On 07/29/2013 09:14 AM, Alon Levy wrote:
Alternative is to leak, and this happens regularely. Perhaps we should
be keeping track and destroying these surfaces later (in case no reset
happens in the middle, which destroys all off screen surfaces anyway).
---
  display/driver.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/display/driver.c b/display/driver.c
index b8050de..aa4fe42 100644
--- a/display/driver.c
+++ b/display/driver.c
@@ -1464,6 +1464,11 @@ VOID APIENTRY DrvDeleteDeviceBitmap(DHSURF dhsurf)

      DEBUG_PRINT((pdev, 3, "%s: %p: %d\n", __FUNCTION__, pdev, surface_id));

+    if (!pdev->enabled) {
+        DEBUG_PRINT((pdev, 3, "%s: device disabled, still destroying\n",
+                    __FUNCTION__));
+    }
+
      ASSERT(pdev, surface_id < pdev->n_surfaces);

      DeleteDeviceBitmap(surface->u.pdev, surface_id,


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]