On Mon, Jun 24, 2013 at 02:31:27PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > gtk/channel-main.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 69 insertions(+), 4 deletions(-) IIUC, implicit in your patch here is that the communication protocol between spice client & guest agent uses guest OS specific line ending markers, and the spice client must do all conversions to guest OS format. Is that really what we want ? Personally I would have said that the line ending markers should be invariant (always \n) in the comms protocol and that each end point must handle conversion to/from \r\n if required. But perhaps there are backwards compat issues forcing your choice here ? Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel