cool looking forward to your patch :P Rob 2013/5/30 Christophe Fergeau <cfergeau@xxxxxxxxxx>: > On Thu, May 30, 2013 at 12:33:31PM +0200, Rob Verduijn wrote: >> Hello, >> >> The 900 patch was to deal with an rpmlint error that prevented the obs >> from publishing the package. >> The rpmlint error was : >> [ 32s] I: Statement might be overflowing a buffer in strncat. Common mistake: >> [ 32s] BAD: strncat(buffer,charptr,sizeof(buffer)) is wrong, it >> takes the left over size as 3rd argument >> [ 32s] GOOD: strncat(buffer,charptr,sizeof(buffer)-strlen(buffer)-1) >> [ 32s] E: xf86-video-qxl bufferoverflowstrncat /usr/include/bits/string3.h:150 > > Ah actually rereading strncat man page a few more times, this seems right. > > Christophe _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel