Re: [PATCH spice-server 03/10] red_worker: fix incorrect is_low_bandwidth after migrating a low bandwidth connection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ack (somehow I missed that we already had a is_low_bandwidth flag in migration data!)


On Wed, May 8, 2013 at 4:06 PM, Yonit Halperin <yhalperi@xxxxxxxxxx> wrote:
rhbz#956345

After a spice session has been migrated, we don't retest the network
(user experience considerations). Instead, we obtain the is_low_bandwidth flag
from the src-server, via the migration data.
Before this patch, if we migrated from server s1 to s2 and then to s3,
and if the connection to s1 was a low bandwidth one, we erroneously
passed is_low_bandwidth=FALSE from s2 to s3.

Cc: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
---
 server/red_worker.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/server/red_worker.c b/server/red_worker.c
index be53c1d..247f153 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -10199,6 +10199,9 @@ static int display_channel_handle_migrate_data(RedChannelClient *rcc, uint32_t s
     } else {
         spice_critical("restoring global lz dictionary failed");
     }
+
+    dcc->common.is_low_bandwidth = migrate_data->low_bandwidth_setting;
+
     if (migrate_data->low_bandwidth_setting) {
         red_channel_client_ack_set_client_window(rcc, WIDE_CLIENT_ACK_WINDOW);
         if (dcc->common.worker->jpeg_state == SPICE_WAN_COMPRESSION_AUTO) {
--
1.8.1.4

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



--
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]