Re: [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

[Marc-André Lureau <marcandre.lureau@xxxxxxxxx>]

So when this happens (even if the agent is fixed to not crash), then we get randomly loaded drivers assigned to channels

A guest monitor 3 might end up on display channel 4 if for example, driver failed to load for card associated to display channel 3..

This means that virt-viewer will show a "waiting for display" message for the disabled monitor, and it will enable monitors on unexpected channels (turning on 3 will enable 4...)

I wonder if the VM shouldn't just refuse to start if this ressource problem occurs.

Is it a VRAM resource limit?

On Fri, May 3, 2013 at 12:57 AM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote:

Hi

On Tue, Apr 30, 2013 at 12:10 PM, Uri Lublin <uril@xxxxxxxxxx> wrote:

     if (display_count) {

There is at least one more use you forgot, and that caused still a crash

 if (min_x || min_y) {

         for (iter = _displays.begin(); iter != _displays.end(); iter++) {

+if (!*iter) {
+   continue;
+}

--
Marc-André Lureau

--
Marc-André Lureau

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel