Re: [PATCH spice-gtk 4/5] usb-device-manager: Fix redirect_on_connect_rules mem-leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 24, 2013 at 09:18:11AM +0200, Hans de Goede wrote:
> On 04/23/2013 08:14 PM, Christophe Fergeau wrote:
> >
> >This should be a g_free
> 
> No, just like the free right above it, it should be a regular free, the rules
> are allocated by usbredirfilter_string_to_rules(), quoting from
> usbredirfilter.h: "the returned rules array should be freed with free()"

Yes, my bad, I was looking at priv->redirect_on_connect during the review,
not priv->redirect_on_connect_rules. The former seems to be leaked as well,
and this one needs g_free().

ACK

Christophe

Attachment: pgpiOJaO4AoQN.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]