Hi,
On 04/23/2013 08:05 PM, Christophe Fergeau wrote:
On Tue, Apr 23, 2013 at 02:19:49PM +0200, Hans de Goede wrote:
Under Windows all calls to spice_usb_device_manager_device_to_libdev may fail,
so error check them all.
I don't think I'd make that conditional on the windows code as this makes
things less readable, and this does not hurt to have these checks on linux.
ACK either way.
I understand, I've actually already thought about this. An additional reason
for having the #ifdef-s is that hopefully one day we will have a better windows
story, and then most of the windows specific handling can go away. So these
#ifdef-s also are sort of a marker of "remove this when the windows stuff is
better". And they lead to a (slightly) smaller binary on Linux.
Regards,
Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel