Re: [PATCH spice-gtk 1/5] usb-device-manager: Avoid needless re-numeration of usb devs under Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 23, 2013 at 02:19:48PM +0200, Hans de Goede wrote:
> libusb_get_device_list() is not exactly a cheap call (lots of sysfs and
> usbfs accesses), so it is worth to avoid it where possible.
> 
> This patch restores the old (pre win32 support addition) of dealing with
> libusb-devices under Linux, it keeps the device from the first lookup
> in spice_usb_device_manager_add_dev cached and uses that throughout.
> 
> This also means that spice_usb_device_manager_device_to_libdev can no
> longer fail under Linux, so no need to error check it.

ACK, with the same comment as in one of the following patch about the not
really needed #if OS_WIN32 not improving readibility.

Christophe

Attachment: pgpV0RhYlV0mp.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]