Hi,
First of all thanks for reviewing this set!
Are you still thinking about:
Patch 2/16: Revert "channel-main: Fix dangling references to freed file-xfer-tasks on agent cancel"
Patch 11/16: channel-main: Don't close the file_stream if callbacks are pending
Or did something eat your mails on these 2?
On 04/09/2013 11:54 AM, Christophe Fergeau wrote:
On Fri, Mar 29, 2013 at 12:40:28PM +0100, Hans de Goede wrote:
Since the agent channel can have a significant latency, it is possible
for a cancel send from the client to the agent and a status message from
the agent to cross each other. If this happens then the file-xfer will no
longer be on the list.
Printing a g_warning on this (rare but triggerable) condition will only get
us hard to debug bug reports, so turn it into a SPICE_DEBUG.
On the other hand, this rare situation occurring could be related to some
mysterious transient bugs that would be reported in the future, so having a
warning being displayed right away is more useful than having to
enable debug before getting a hint that this rare situation occurred.
So I'd tend to keep a g_warning, potentially with an improved message
rather than a g_debug (even if it can occur in legit cases), but no strong
feeling either way.
I tend to usually start even GUI apps from a terminal, and the amount of
g_warning-s the average gnome / gtk app pollutes the terminal with is
just not funny.
Now most of these are actually bugs which need fixing, but still I find
the experience appalling. So since this is something which can happen
under normal circumstances and I'm allergic to g_warning-s I would really
like to make this a SPICE_DEBUG.
Regards,
Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel