> Dear Jeremy, > This is a *new* version of the patch that address your comments. > It sends both down and up keys messages as well as the key modifiers. > It also fixes the white spaces you have commented on. I'm very sorry; I jumped to the wrong conclusion based on the --- Forwarded --- header line in your message, and the fact that the patch is visually similar. Please accept my apologies for misunderstanding. Unfortunately, I'm still not quite happy with your patch, although I think it's quite close. Specifically, I would like you to respect and use the 'Ctrl_state' and 'Alt_state' global variables. For example, if Ctrl_state is == 1 on your function entry, then you should not need to do anything with the ctrl key - it should already be down. Alternately, if you want to be sure to send a down/up sequence, then I'd ask that if on entry the ctrl was down, you send a down sequence at the end of your function to return it to the down state. Cheers, Jeremy _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel