On Mon, Mar 11, 2013 at 01:56:04PM +0100, Marc-André Lureau wrote: > On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau > <cfergeau@xxxxxxxxxx> wrote: > > > +AC_ARG_ENABLE([xpi], > > + [AS_HELP_STRING([--enable-xpi], > > + [Enable compilation of an xpi package])], > > + [], [enable_xpi=no]) > > +if test x"$enable_xpi" != xno; then > > PKG_CHECK_MODULES(XUL, libxul-embedding >= 10) > > AC_SUBST(XUL_CFLAGS) > > AC_SUBST(XUL_LIBS) > > @@ -36,6 +41,8 @@ XUL_INCLUDEDIR=`pkg-config --variable=includedir libxul` > > XUL_IDLDIR=`pkg-config --variable=idldir libxul` > > AC_SUBST(XUL_INCLUDEDIR) > > AC_SUBST(XUL_IDLDIR) > > +fi > > +AM_CONDITIONAL([BUILD_XPI], [test x"$enable_xpi" != xno]) > > Please add it to the configure summary. > > Do we want it to be disabled by default? If yes, ack, if no then we > may want to invert it. Currently (as in 'in git master before any of my patches'), the .xpi is built but not installed, and as far as I know, we don't have any user of it (if I'm wrong, please let me know!), so building it by default does not seem very useful to me. Christophe
Attachment:
pgp4JPs4bjIgm.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel