Re: [PATCH spice-gtk 12/15] channel-main: file_xfer_failed -> file_xfer_completed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 03/10/2013 03:47 PM, Marc-André Lureau wrote:
On Sun, Mar 10, 2013 at 3:45 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Calling it twice won't return an error, but it will cause file_xfer_close_cb
to get called twice, and thus try to free the SpiceFileXferTask twice.

I understand it uses ->closed on a pointer that got free then?

No the problem is that for example a file-io error can happen, and then before the
file_xfer_close_cb runs the connection gets terminated and agent_reset calls
file_xfer_completed a 2nd time (since it is still in the xfer list).

Regards,

Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]