Re: [PATCH spice-gtk 1/4] channel-main: Fix dangling references to freed file-xfer-tasks on agent cancel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 04, 2013 at 07:46:09PM +0100, Hans de Goede wrote:
> On 03/04/2013 04:59 PM, Christophe Fergeau wrote:
> >I don't know how many elements are typically in this loop, but calling
> >g_slist_remove from a g_list_foreach callback will give you quadratic
> >behaviour. Doing the iteration by hand could probably help avoiding this,
> >but if this list typically has few elements, it's probably not worth the
> >trouble.
> 
> The list typically has few elements, and there will be only one flush in
> the list per task, so g_slist_remove will be called once (or not at all).

Ok, sounds good then, ACK

Christophe

Attachment: pgp2RlsZZxtJP.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]