On Tue, Jan 29, 2013 at 05:45:00PM +0100, Marc-André Lureau wrote: > On Tue, Jan 29, 2013 at 5:10 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > The patch seems to have been pushed without addressing this comment? > > Ah sorry, I missed the comments. There is already a > g_clear_object(&s->proxy); or I don't get what you mean. The code is static void update_proxy(SpiceSession *self, const gchar *str) { SpiceSessionPrivate *s = self->priv; SpiceProxy *proxy = NULL; GError *error = NULL; if (str == NULL) str = g_getenv("SPICE_PROXY"); if (str == NULL || *str == 0) return; update_proxy(session, NULL); will never unset an already set proxy. Christophe
Attachment:
pgp8f5JqoHgFN.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel