On 01/24/2013 05:37 AM, Hans de Goede wrote:
Hi, Overall comments: 1) I've run several tests with this, and this looks good to go.
Great, thanks!
2) As Alon said, please split of the #if 0 blocks removal, I agree they can be removed after this patch, but lets do so in a follow-up patch
See my separate email on that.
3) I don't like the hardcoded 1024x768, yes I know it was there before, but while at it can you please add: #define DEFAULT_WIDTH 1024 #define DEFAULT_HEIGHT 768 To the top of qxl_driver.c and use those in the check to set the preferred flag?
Sure.
Also one small white spice issues, see comments inline.
I hate people that send patches that make git am yarf :-/. I'll fix that as well. I have one bit of due diligence I'm going to do as well; (I wanted to make sure the change to qxl_resize_primary_to_virtual shouldn't be it's own patch, and maybe see if that's what led to my NumHeads confusion), but I'll hopefully respin and submit today or tomorrow. Cheers, Jeremy p.s.
Hmm, I would expect the stock fc18 to work actually ... Any chance you perhaps also rebuild qemu between the 2 tries ?
I'm glad it turned out not be my operator error, this time. That probably drops me from an average operator error rate of 99% to 98% <grin>. _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel