Re: [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/23/2012 01:10 PM, Marc-André Lureau wrote:
Hi

----- Mensaje original -----
Hi Marc-André,

On 11/23/2012 12:53 PM, Marc-André Lureau wrote:
Hi


<snip>


+enum {
+    VD_AGENT_FILE_XFER_RESULT_SUCCESS,

What does success indicates? When is it sent?

I believe that Dunrong Huang based this second version on my protocol
proposal,
which answers this and a few of your other questions, see this mail:
http://lists.freedesktop.org/archives/spice-devel/2012-November/011485.html

Ok, may I suggest XFER_STATUS_CAN_SEND_DATA ?


+1

Instead of those fields that will be hard to extend and that mostly
only concern the guest agent, I would consider a key-value text
such as:

[vdagent-file-xfer]
type=regular
mime=text/plain
name=foo.sh
time-modified=1353085649
time-...
can-read=true
can-execute=true
can-write=false
size=25
I like, may I suggest we use this to implement this:
http://ndevilla.free.fr/iniparser/

I would go for glib keyfile. But if we still have reasons to avoid glib usage, sure.

See my reply to myself. I'm fine with using glib-keyfile. I wonder what this
means for the windows agent though?

Regards,

Hans


cheers

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]