On Wed, Nov 07, 2012 at 03:19:46PM +0200, Arnon Gilboa wrote: > -move virtio-serial use from vdservice to vdagent > -remove named pipe between vdservice & vdagent > > pros: > -make agent independent so it can run seperately without service > (e.g. single user, testing) > -simplify service to just a launcher of agents > -performance - data is currently copied on pipe read/write > -separation between user sessions, no communication with service > -easier to debug No permissions issues wrt user privileges when an unpriviledged windows user tries to use virtio-serial? I'm assuming the agent will run the windows user that is logged in. Christophe > > cons: > -when switching between users client will switch to server mode for a few ms > > Arnon Gilboa (5): > vdservice: remove virtio-serial & pipe usage > vdagent: mv vdi_port files from vdservice > vdagent: use virtio-serial, remove pipe usage > vdagent: remove pipe common defs > vdagent: extract event_dispatcher from input_desktop_message_loop > > common/vdcommon.h | 31 --- > vdagent/pci_vdi_port.cpp | 132 +++++++++++ > vdagent/pci_vdi_port.h | 59 +++++ > vdagent/vdagent.cpp | 498 ++++++++++++++++++++--------------------- > vdagent/vdagent.vcproj | 32 +++- > vdagent/vdi_port.cpp | 90 ++++++++ > vdagent/vdi_port.h | 75 ++++++ > vdagent/virtio_vdi_port.cpp | 187 +++++++++++++++ > vdagent/virtio_vdi_port.h | 33 +++ > vdservice/pci_vdi_port.cpp | 132 ----------- > vdservice/pci_vdi_port.h | 59 ----- > vdservice/vdi_port.cpp | 90 -------- > vdservice/vdi_port.h | 75 ------ > vdservice/vdservice.cpp | 471 +++----------------------------------- > vdservice/vdservice.vcproj | 24 -- > vdservice/virtio_vdi_port.cpp | 187 --------------- > vdservice/virtio_vdi_port.h | 33 --- > 17 files changed, 887 insertions(+), 1321 deletions(-) > create mode 100644 vdagent/pci_vdi_port.cpp > create mode 100644 vdagent/pci_vdi_port.h > create mode 100644 vdagent/vdi_port.cpp > create mode 100644 vdagent/vdi_port.h > create mode 100644 vdagent/virtio_vdi_port.cpp > create mode 100644 vdagent/virtio_vdi_port.h > delete mode 100644 vdservice/pci_vdi_port.cpp > delete mode 100644 vdservice/pci_vdi_port.h > delete mode 100644 vdservice/vdi_port.cpp > delete mode 100644 vdservice/vdi_port.h > delete mode 100644 vdservice/virtio_vdi_port.cpp > delete mode 100644 vdservice/virtio_vdi_port.h > > -- > 1.7.4.1 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
pgpFchS1owMZD.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel