Re: [RFC] [PATCH spice-gtk 0/4] simply implement of file drag-and-drop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/05/2012 11:01 AM, Dunrong Huang wrote:
These patches simply implement file drag-and-drop from client to guest.

There are some TODOs needed to be done:
   * transfer multiple files and directories
   * check whether guest has enough space to store file
   * a progress bar that allows user to cancels file transfer,
     since we always pre-cache before sending file content,
	it has a little difficult to finish.

Comments are welcome, please review!

Dunrong Huang (4):
   DND: Add spice_main_dnd_*() for sending dnd message to guest
   DND: Add spice-dnd.c
   DND: handle "drag-data-received" signal
   DND: Set a maximum allowed file size

  gtk/Makefile.am         |   1 +
  gtk/channel-main.c      |  16 +++++++
  gtk/channel-main.h      |   3 ++
  gtk/map-file            |   3 ++
  gtk/spice-dnd.c         | 122 ++++++++++++++++++++++++++++++++++++++++++++++++
  gtk/spice-dnd.h         |  24 ++++++++++
  gtk/spice-glib-sym-file |   3 ++
  gtk/spice-widget.c      |  48 +++++++++++++++++++
  8 files changed, 220 insertions(+)
  create mode 100644 gtk/spice-dnd.c
  create mode 100644 gtk/spice-dnd.h


Nice.

A comment/suggestion about the name (of structures, functions, constants, etc): maybe call it file-copy/file-transfer instead of DND.


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]