Re: [PATCH spice-gtk 3/6] spice-channel: remove unnecessary g_socket_close()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 24, 2012 at 03:58:16PM +0200, Marc-André Lureau wrote:
> ---
>  gtk/spice-channel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
> index 37198f5..eb113db 100644
> --- a/gtk/spice-channel.c
> +++ b/gtk/spice-channel.c
> @@ -2379,7 +2379,6 @@ static void channel_reset(SpiceChannel *channel, gboolean migrating)
>      }
>  
>      if (c->sock) {
> -        g_socket_close(c->sock, NULL);

This is not fully useless if we are leaking a ref to c->sock somewhere, but
ACK anyway.

Christophe

>          g_object_unref(c->sock);
>          c->sock = NULL;
>      }
> -- 
> 1.7.11.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: pgpu5fis7uv87.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]