On Sat, Sep 29, 2012 at 11:57:07AM +0200, Hans de Goede wrote: > Hi, > > On 09/28/2012 09:18 PM, Christophe Fergeau wrote: > >On Fri, Sep 21, 2012 at 05:32:21PM +0200, Hans de Goede wrote: > >>The spice-usbredir-filter cmdline option was not chosen well, as it does > >>not indicate what it filters. Now that we are also getting a filter for > >>selecting already plugged in devices to redirect when a spice connection gets > >>established, it needs to be renamed to make its function more clear. > > > >This is some kind of ABI break as scripts using the old option name will be > >broken. > > I don't really consider cmdline options part of the ABI. > > You don't seem to be reusing the old name for something else in > >this series, so maybe we can keep it and output a deprecation warning when > >it's used for now? On the other hand, this option is probably not widely > >used, so maybe breaking things now will not be too bad... > >https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=823541 seems to > >indicate there's at least one user of it. > > That bug is from QA, so yes QA is using the cmdline option for testing, not sure > if that really counts as "user". I expect most users of the filter to use it > through the XPI / ActiveX and that path is not being broken. > > TBH I would prefer to just go for a clean break rather then doing some compat > stuff. Is that ok with you? If you insist on it... Hopefully the option is obscure enough ;) Christophe
Attachment:
pgpcRIfodvEW3.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel