Re: [5/ ]QUIC_IMAGE_TYPE_RGB24 decodes the same as QUIC_IMAGE_TYPE_RGB32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 24, 2012 at 10:49:53AM -0500, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric@xxxxxxxxxxxxxxx>
> @@ -1014,7 +1012,7 @@ QuicEncoder.prototype.simple_quic_decode = function(buf)
>     var stride = 4; /* FIXME - proper stride calc please */
>     if (!this.quic_decode_begin(buf))
>         return undefined;
> -    if (this.type != QUIC_IMAGE_TYPE_RGB32 && this.type != QUIC_IMAGE_TYPE_RGBA)
> +    if (this.type != QUIC_IMAGE_TYPE_RGB32 && this.type != QUIC_IMAGE_TYPE_RGB24)
>         return undefined;
>     var out = new Uint8Array(this.width*this.height*4);
>     out[0] = 69;
> @@ -1057,7 +1055,7 @@ function convert_spice_quic_to_web(context, spice_quic)
>         ret.data[i + 0] = spice_quic.outptr[i + 2];
>         ret.data[i + 1] = spice_quic.outptr[i + 1];
>         ret.data[i + 2] = spice_quic.outptr[i + 0];
> -        if (spice_quic.type == 4)
> +        if (spice_quic.type !== QUIC_IMAGE_TYPE_RGBA)
>             ret.data[i + 3] = 255;
>         else
>             ret.data[i + 3] = spice_quic.outptr[i + 3];

Looks like the end of the patch is mixed with unrelated RGBA changes?

Christophe

Attachment: pgpEkoKFlzoFH.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]