2012/9/9 Yaniv Kaul <ykaul@xxxxxxxxxx>: > channel-display.c: In function 'spice_display_channel_reset_capabilities': > channel-display.c:685:247: error: 'SPICE_DISPLAY_CAP_A8_SURFACE' undeclared (first use in this function) > channel-display.c:685:247: note: each undeclared identifier is reported only once for each function it appears in > make[4]: *** [channel-display.lo] Error 1 > > > I'm sure it's something I'm again failing to understand. > I have it in spice-protocol repository, but not in ./spice-common/spice-protocol/spice/protocol.h so I reckon the spice-protocol module within spice-gtk is not updated? > SPICE_DISPLAY_CAP_A8_SURFACE is intruduced by 8459b35ec0a2c1cddd7dab8b726e752bcde4c609(Add A8 surface capability) in spice-protocol, But the changes of submodule spice-protocol has not been pushed by maintainers > Same with spice itself: > [ykaul@ykaul spice]$ grep -R SPICE_DISPLAY_CAP_A8_SURFACE * > client/display_channel.cpp: set_capability(SPICE_DISPLAY_CAP_A8_SURFACE); > server/red_worker.c: if (red_channel_client_test_remote_cap(rcc, SPICE_DISPLAY_CAP_A8_SURFACE)) > server/red_worker.c: SET_CAP(caps, SPICE_DISPLAY_CAP_A8_SURFACE); > > And it fails compilation as well. > Y. > > > ----- Original Message ----- >> gtk/channel-display.c | 1 + >> 1 file changed, 1 insertion(+) >> >> New commits: >> commit 1bcb20fd74502642bc057b16058c89aa43a4b819 >> Author: Søren Sandmann Pedersen <ssp@xxxxxxxxxx> >> Date: Sun Sep 2 16:38:28 2012 -0400 >> >> Advertise SPICE_DISPLAY_CAP_A8_SURFACE >> >> diff --git a/gtk/channel-display.c b/gtk/channel-display.c >> index 99fe9c9..326ad22 100644 >> --- a/gtk/channel-display.c >> +++ b/gtk/channel-display.c >> @@ -682,6 +682,7 @@ static void >> spice_display_channel_reset_capabilities(SpiceChannel *channel) >> spice_channel_set_capability(SPICE_CHANNEL(channel), >> SPICE_DISPLAY_CAP_SIZED_STREAM); >> spice_channel_set_capability(SPICE_CHANNEL(channel), >> SPICE_DISPLAY_CAP_MONITORS_CONFIG); >> spice_channel_set_capability(SPICE_CHANNEL(channel), >> SPICE_DISPLAY_CAP_COMPOSITE); >> + spice_channel_set_capability(SPICE_CHANNEL(channel), >> SPICE_DISPLAY_CAP_A8_SURFACE); >> } >> >> static void spice_display_channel_init(SpiceDisplayChannel *channel) >> >> _______________________________________________ >> Spice-commits mailing list >> Spice-commits@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/spice-commits >> > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel -- Best Regards, Dunrong Huang _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel