Re: [PATCH 1/3] Add support for LZ compression of A8 images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 08/19/2012 10:53 PM, Søren Sandmann Pedersen wrote:
Graduality is irrelevant for A8 images, so instead of using RGB-ness
as a short-cut, add a new macro BITMAP_FMT_HAS_GRADUALITY() that
returns true for the existing RGB images, but false for A8.
---
  server/red_common.h    |  2 +-
  server/red_parse_qxl.c |  2 +-
  server/red_worker.c    | 23 +++++++++++++++--------
  spice-common           |  2 +-
  4 files changed, 18 insertions(+), 11 deletions(-)


<snip>

diff --git a/server/red_worker.c b/server/red_worker.c
index 9330fff..59749f9 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c

<snip>

@@ -5882,7 +5888,8 @@ static const LzImageType MAP_BITMAP_FMT_TO_LZ_IMAGE_TYPE[] = {
      LZ_IMAGE_TYPE_RGB16,
      LZ_IMAGE_TYPE_RGB24,
      LZ_IMAGE_TYPE_RGB32,
-    LZ_IMAGE_TYPE_RGBA
+    LZ_IMAGE_TYPE_RGBA,
+    LZ_IMAGE_TYPE_A8
  };

  typedef struct compress_send_data_t {

Here you are using A8 again, versus 8BIT_A in some other patches, please pick one and
be consistent about it. Other then that this and the other 2 patches look good.

<snip>

Regards,

Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]