On Wed, Aug 08, 2012 at 05:26:09AM -0400, Yaniv Kaul wrote:
> > static int reds_send_link_ack(RedLinkInfo *link)
> > {
> > SpiceLinkHeader header;
> > @@ -1224,12 +1242,12 @@ static int reds_send_link_ack(RedLinkInfo
> > *link)
> > RedChannelCapabilities *channel_caps;
> > BUF_MEM *bmBuf;
> > BIO *bio;
> > - int ret = FALSE;
> > + int ret = FALSE, *commom_caps = -1, *caps = -1;
> >
> > header.magic = SPICE_MAGIC;
> > header.size = sizeof(ack);
> > - header.major_version = SPICE_VERSION_MAJOR;
> > - header.minor_version = SPICE_VERSION_MINOR;
> > + header.major_version = htole32(SPICE_VERSION_MAJOR);
> > + header.minor_version = htole32(SPICE_VERSION_MINOR);
>
> If you are already touching it, move it to 1 byte each (http://spice-space.org/page/ProtocolChanges#Protocol_Version_field_.28minor_.26_major.29_should_be_1_byte_sized_each)
No, we don't want to do that. The changes in this patch don't break the
on-wire protocol, what you suggest would break backward compatibility.
Christophe
Attachment:
pgpWYysQX4hes.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel