Re: [PATCH] spice-ppc: adds powerpc64 mem barriers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

Thanks for looking into this! Just a few random questions below, mostly
because I'm curious ;)

On Tue, Aug 07, 2012 at 03:46:40PM -0300, sombrafam@xxxxxxxxx wrote:
> From: Erlon Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> 
> 
> Signed-off-by: Erlon R. Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabiano Fidêncio <Fabiano.Fidêncio@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Rafael F. Santos <Rafael.Santos@xxxxxxxxxxxxxxxxxxxxx>
> 
> ---
>  spice/barrier.h |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/spice/barrier.h b/spice/barrier.h
> index 710da09..77bce2e 100644
> --- a/spice/barrier.h
> +++ b/spice/barrier.h
> @@ -36,9 +36,11 @@
>  
>  #ifdef __i386__
>  #define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%esp)": : :"memory")
> -#else
> +#elif defined __x86_64__
>  //mfence
>  #define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%rsp)": : :"memory")
> +#elif defined __PPC64__
> +#define spice_mb()   __asm__ __volatile__ ("sync" : : : "memory")

Do we need a full sync here? Would an lwsync be enough?
Without this, what happens? Is compilation broken? Are things buggy?

Thanks,

Christophe

Attachment: pgpooi1BWwYTT.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]