Hi,
I've reviewed all of the patches, I've comments to a few of them, see my
individual replies to them. Overall the patchset looks good. Although I
hope in the future we can get hotplug support at the libusb level,
and hopefully more or less revert to the old situation where
libusb_device == SpiceUsbDevice, we'll see :)
Regards,
Hans
On 07/05/2012 10:43 PM, Uri Lublin wrote:
New in V4:
- Using g_win32_output_stream and g_win32_input_stream instead of our
own named-pipe class.
- Keeping SpiceUsbDevice as a BOX type, but making it hold
a SpiecUsbDeviceInfo instead of a libusb_device.
- Ignoring win-usb-dev (udev) events caused by driver install
and uninstall.
- code modifications following some review comments.
Arnon Gilboa (1):
Windows mingw: usb: implement GUdevDevice & GUdevClient for windows
Uri Lublin (16):
spicy: more informative presentation of usb devices in menu
Introduce SpiceUsbDeviceInfo to be kept instead of a libusb_device
Make SpiceUsbDevice a box for SpiceUsbDeviceInfo, instead of a box
for libusb_device
Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR
Windows mingw: usb: Dynamically install a libusb driver for USB
devices
usb-device-manager: warn if a device to remove was not found
win-usb-driver-install: add capability to remove (uninstall) a win
usb driver
Win32/mingw: usb-device-manager: uninstall win usb driver upon device
disconnect
Win32/mingw: win-usb-dev: skip hubs
usb-device-manager: add a helper function to find a usb device <bus,
addr>
usb-device-manager: use find_device() in libdev_to_device()
usb-device-manager.c: add_dev: ignore already known devices
usb-device-manager: add 'state' field to SpiceUsbDeviceInfo
usb-device-manager: mingw: keep driver install/uninstall state of a
device
usb-device-manager: mingw: ignore "remove" udev event when
un/installing a driver
controller/test.c: mingw: fix compiler bad param warning for ReadFile
configure.ac | 15 +-
gtk/Makefile.am | 18 ++
gtk/channel-usbredir.c | 2 +-
gtk/controller/test.c | 4 +-
gtk/spicy.c | 2 +-
gtk/usb-device-manager-priv.h | 10 +-
gtk/usb-device-manager.c | 603 ++++++++++++++++++++++++++++++++++++-----
gtk/win-usb-clerk.h | 35 +++
gtk/win-usb-dev.c | 532 ++++++++++++++++++++++++++++++++++++
gtk/win-usb-dev.h | 110 ++++++++
gtk/win-usb-driver-install.c | 414 ++++++++++++++++++++++++++++
gtk/win-usb-driver-install.h | 104 +++++++
12 files changed, 1776 insertions(+), 73 deletions(-)
create mode 100644 gtk/win-usb-clerk.h
create mode 100644 gtk/win-usb-dev.c
create mode 100644 gtk/win-usb-dev.h
create mode 100644 gtk/win-usb-driver-install.c
create mode 100644 gtk/win-usb-driver-install.h
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel