Re: [spice-gtk Win32 v3 05/12] Make SpiceUsbDevice a gobject, instead of a box for libusb_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 28, 2012 at 3:46 AM, Uri Lublin <uril@xxxxxxxxxx> wrote:
> -#define SPICE_TYPE_USB_DEVICE                    (spice_usb_device_get_type())
> +
>
>  typedef struct _SpiceUsbDeviceManager SpiceUsbDeviceManager;
>  typedef struct _SpiceUsbDeviceManagerClass SpiceUsbDeviceManagerClass;
>  typedef struct _SpiceUsbDeviceManagerPrivate SpiceUsbDeviceManagerPrivate;
>
> -typedef struct _SpiceUsbDevice SpiceUsbDevice;
>
>  /**
>  * SpiceUsbDeviceManager:
> @@ -85,7 +85,6 @@ struct _SpiceUsbDeviceManagerClass
>     gchar _spice_reserved[SPICE_RESERVED_PADDING];
>  };
>
> -GType spice_usb_device_get_type(void);

This change will perhaps not break API, but you are definetly going to
break ABI if you replace boxed pointers with objects in public API.


-- 
Marc-André Lureau
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]