Re: [PATCH spice-gtk 2/4] Add a desktop-integration helper class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 06/24/2012 02:07 AM, Marc-André Lureau wrote:
Hi

On Sun, Jun 24, 2012 at 1:39 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
it can be simplified, resulting in simpler API and less code.

No it cannot, using a hidden window for this is just plain wrong! One is
supposed to use real toplevel windows with the inhibit API.


Well, in fact that toplevel_xid is optionnal, and is used for
eventually taking application screenshots (only if possible).

Oh, I was under the impression that the xid would be used to monitor the
window going away and automatically uninhibit when it is gone. Since that
is not the case I agree with you that just using a single inhibit with a
xid of 0 and ref-counting is much better. I'll rewrite my patch-set to
work this way tomorrow.

Regards,

Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]