Hi,
On 06/14/2012 12:05 AM, Marc-André Lureau wrote:
Hi
On Wed, Jun 13, 2012 at 7:07 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
We need to integrate closely with the desktop environment of the user in
several cases. Some examples are disabling auto-mounting when auto-usbredir
is active (rhbz#812972), and disabling the screensaver when fullscreen
(fdo#34793).
Unfortuntely these kinds of things require desktop environment specific
handling. Therefor this patch introduces a desktop-integration helper class,
which is to server as a container for all sort of desktop environment specific
functions.
For now it just supports disabling automounting under Gnome-3, another patch
extending it to also support disabling automounting under Gnome-2 is in the
pipeline.
Looks reasonable to me, however, I don't see why it should be in
spice-glib, since it's very much desktop related. Wouldn't it make
> more sense in spice-gtk?
I actually put it in spice-gtk at first, but that does not work very well
because usb-device-manager needs access to the automount disable functionality.
> Since it's not directly dependent and related
to a particular spice session, it could perhaps even be a separate
library (although for now, a few extra functions and dependency in
spice-gtk is surely fine).
There is various state inside, which needs to be coupled to some object,
using the session for this seems best.
Regards,
Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel