Re: [PATCH] make celt to be optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.06.2012 16:28, Alon Levy wrote:
> On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote:
>> Makes sense to me though I've only looked quickly through it. Since it
>> works for you, I'm in favour of committing it if noone disagrees.
> 
> I agree. Would you do a review and ack?

Please don't apply it without at least minimal testing.  I know
right to nothing about spice and celt, the changes I made are
purely mechanical, without understanding what's going on in a
"big picture" (I ofcourse tried to understand the "small picture",
the code I touched).  And I since I don't know how it works, I'm
not sure I can perform any reasonable testing.  For one, I'm not
even sure I actually used spice way to transmit sound, -- it
looked that way, but I'm not sure.  Just a minimal testing is
very welcome.

Thank you!

/mjt
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]