On 05/22/2012 01:37 AM, Marc-André Lureau wrote:
Hi
On Sun, May 20, 2012 at 6:34 PM, Uri Lublin<uril@xxxxxxxxxx> wrote:
For windows GUDEV is not required
- GUDEV is alwasy checked as part of USBREDIR, and fails
if USBREDIR but no GUDEV on non-windows.
misc spelling alwasy/always
Yes.
- Added GUDEV env-variables in gtk/Makefile.am
It's a Makefile variable.
What's your point ? This line can be removed from the log message ?
Before gudev was part of USBREDIR, now it has it's own variables.
+ # require GUDEV unless os_win32 is true
+ PKG_CHECK_MODULES([GUDEV],
+ [gudev-1.0],
+ [have_gudev=yes],
+ [have_gudev=no])
+ if test "x$have_gudev" = "xyes"; then
+ AC_DEFINE(USE_GUDEV, [1], [Define if supporting gudev])
+ fi
I guess you could do the check only on non-win32.
I can, and set have_gudev to "no".
What's the benefit, smaller running time of configure ? better
separation between different tests ?
AM_CONDITIONAL([WITH_USBREDIR], [test "x$have_usbredir" = "xyes"])
+AM_CONDITIONAL([WITH_GUDEV], [test "x$have_gudev" = "xyes"])
This conditional is not needed.
OK.
What is the different between WITH_FOO and USE_FOO ?
The rational was "if USBREDIR has one, GUDEV will have one too".
+# for non-win32 usbredir requires gudev
+if test "x$have_usbredir" = "xyes"&& test "x$have_gudev" = "xno"&& \
+ test "x$os_win32" = "xno"; then
+ AC_MSG_ERROR([usbredir requested but required gudev is not available])
+fi
If you move the check above, you can print an error there.
I can do that. What's the benefit ?
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel