----- Mensaje original ----- > On Sun, May 13, 2012 at 11:58:33AM +0300, Alon Levy wrote: > > > +enum { > > > + QXL_ESCAPE_SET_CUSTOM_DISPLAY = 0x10001, > > > +}; > > > + > > > +typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay { > > > + uint32_t xres; > > > + uint32_t yres; > > > + uint32_t bpp; > > > +} QXLEscapeSetCustomDisplay; > > > > Do you think we should add fields for later having multiple outputs > > on a > > single device, i.e. VidPN ? ACK if you think this is premature. > > And do we care at all about the size of this structure? uint16_t > xres, uint16_t yres > and uint8_t bpp *should* (famous last words) be enough. - ULONG is what is used in driver API: http://msdn.microsoft.com/en-us/library/windows/hardware/ff570521%28v=vs.85%29.aspx - we don't rely on Windows types and headers in the protocol - uint32_t is more explicit and equivalent to ULONG - (stddef.h doesn't work well with driver code, and it caused a number of errors when included) _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel