On Mon, Mar 17, 2025 at 04:04:56PM +0800, xie.ludan@xxxxxxxxxx wrote: > From: XieLudan <xie.ludan@xxxxxxxxxx> > > Follow the advice in Documentation/filesystems/sysfs.rst: > show() should only use sysfs_emit() or sysfs_emit_at() when formatting > the value to be returned to user space. > > Signed-off-by: XieLudan <xie.ludan@xxxxxxxxxx> > --- > arch/sparc/kernel/vio.c | 2 +- Do you have this hardware and have tested it? If not, I wouldn't mess with existing code, just follow the documentation for new submissions, leave old stuff alone as it's already working. thanks, greg k-h