Hi David, On 2024-12-08 11:03:23+0000, David Laight wrote: > From: liujing > > Sent: 06 December 2024 09:24 > > > > There is a static checker warning, so move the va_end call before > > exit(1). Since the exit(1) function terminates the program, any code > > after exit(1) is unreachable thus notexecuted. Placing va_end() before > > exit() ensures that the va_list is properly cleaned up. > > Aren't you just adding 'bloat' to the vdso? > (It might even be space limited?) This is about the build time tool "vdso2c", which converts the VDSO binary into a C file to be compiled and linked into the kernel. So it can't be a runtime issue. That should probably been in the patch subject. > If you are calling exit() then there is no need to tidy up the va_list. > Much the same as there is no need to call free() or close() all fd. > > I'd probably have written it as: > // va_end(ap); > exit(1); > > David > > > > Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx> > > --- > > V1 -> V2: Modify the commit information and title description > > > > diff --git a/arch/sparc/vdso/vdso2c.c b/arch/sparc/vdso/vdso2c.c > > index dc81240aab6f..372e3330850a 100644 > > --- a/arch/sparc/vdso/vdso2c.c > > +++ b/arch/sparc/vdso/vdso2c.c > > @@ -90,8 +90,8 @@ static void fail(const char *format, ...) > > vfprintf(stderr, format, ap); > > if (outfilename) > > unlink(outfilename); > > - exit(1); > > va_end(ap); > > + exit(1); > > } > > > > /* > > -- > > 2.27.0
