On Thu, Oct 31, 2024 at 10:07 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> On Wed, Oct 30, 2024 at 5:44 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > On Wed, Oct 30, 2024 at 4:45 PM Andreas Larsson <andreas@xxxxxxxxxxx> wrote:
> > > On 2024-10-30 11:03, Geert Uytterhoeven wrote:
> > > > While the Aeroflex Gaisler GRGPIO driver has no build-time dependency on
> > > > gpiolib-of, it supports only DT-based configuration, and is used only on
> > > > DT systems. Hence re-add the dependency on OF_GPIO, to prevent asking
> > > > the user about this driver when configuring a kernel without DT support.
> > > >
> > > > Fixes: bc40668def384256 ("gpio: grgpio: drop Kconfig dependency on OF_GPIO")
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > > > --- a/drivers/gpio/Kconfig
> > > > +++ b/drivers/gpio/Kconfig
> > > > @@ -341,6 +341,7 @@ config GPIO_GRANITERAPIDS
> > > >
> > > > config GPIO_GRGPIO
> > > > tristate "Aeroflex Gaisler GRGPIO support"
> > > > + depends on OF_GPIO || COMPILE_TEST
> > > > select GPIO_GENERIC
> > > > select IRQ_DOMAIN
> > > > help
> > >
> > > Or alternatively:
> > >
> > > depends on OF || COMPILE_TEST
> > >
> > > Reviewed-by: Andreas Larsson <andreas@xxxxxxxxxxx>
>
> > Yes, if anything it should depend on CONFIG_OF but is this really an
> > issue if this shows up as an option in Kconfig? It's not a hard no
> > from my side and I have heard a similar comment from Torvalds already
> > but I really don't get it: do people go through all the make config
> > prompts on a daily basis instead of using some base config and doing
> > make olddefconfig or menuconfig at worst?
>
> I never use "make olddefconfig" or "make menuconfig".
> I always use "make oldconfig". How else do you find out about new
> driver support for the hardware you are interested in?
> I also compare the resulting config to what I had before, to catch new
> dependencies that suddenly make an option unavailable.
>
> The kernel has 20K Kconfig options. It's nearly impossible to configure
> a kernel from scratch. Being able to filter out the thousands of
> questions that cannot possibly apply to the hardware you are configuring
> your kernel for is a big win. Times the number of people doing this...
>
> Thanks for applying ;-)
>
Well I didn't. Not yet anyway. Please make it depend on CONFIG_OF if
you really want it.
Bartosz
