On Sun, Aug 04 2024 at 17:30, Koakuma wrote: > Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: >> Why does this sparc'ism need to be in generic code? > > Doesn't x86 also have a couple functions that live in math64.h anyway? No. Both functions are used in the generic lib/vdso/ code. > That's why I thought it is fine to put it in there... > > In any case, though, I am open to moving the function to sparc directory, > if that is indeed the proper place for that function. I think so as sparc is having it's own VDSO implementation and does not use the generic one. Thanks, tglx