Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Mina Almasry <almasrymina@xxxxxxxxxx>

Subject: Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

From: Christoph Hellwig <hch@xxxxxxxxxxxxx>

Date: Wed, 1 May 2024 00:54:41 -0700

Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Amritha Nambiar <amritha.nambiar@xxxxxxxxx>, Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>, Alexander Mikhalitsyn <alexander@xxxxxxxxxxxxx>, Kaiyuan Zhang <kaiyuanz@xxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, Yunsheng Lin <linyunsheng@xxxxxxxxxx>, Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Arseniy Krasnov <avkrasnov@xxxxxxxxxxxxxxxxx>, Aleksander Lobakin <aleksander.lobakin@xxxxxxxxx>, Michael Lass <bevan@xxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Lorenzo Bianconi <lorenzo@xxxxxxxxxx>, Richard Gobert <richardbgobert@xxxxxxxxx>, Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx>, Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>, Johannes Berg <johannes.berg@xxxxxxxxx>, Abel Wu <wuyun.abel@xxxxxxxxxxxxx>, Breno Leitao <leitao@xxxxxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, David Wei <dw@xxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>, Shakeel Butt <shakeel.butt@xxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>

In-reply-to: <20240403002053.2376017-3-almasrymina@google.com>

References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-3-almasrymina@google.com>

Still NAK to creating aⅺbitrary hooks here.  This should be a page or
dmabuf pool and not an indirect call abstraction allowing random
crap to hook into it.