Re: [RFC PATCH net-next v6 03/15] net: page_pool: factor out page_pool recycle check

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Mina Almasry <almasrymina@xxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-alpha@xxxxxxxxxxxxxxx>, <linux-mips@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, <sparclinux@xxxxxxxxxxxxxxx>, <linux-trace-kernel@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <linux-kselftest@xxxxxxxxxxxxxxx>, <linux-media@xxxxxxxxxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>

Subject: Re: [RFC PATCH net-next v6 03/15] net: page_pool: factor out page_pool recycle check

From: Yunsheng Lin <linyunsheng@xxxxxxxxxx>

Date: Tue, 5 Mar 2024 20:55:01 +0800

Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, David Wei <dw@xxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>

In-reply-to: <20240305020153.2787423-4-almasrymina@google.com>

References: <20240305020153.2787423-1-almasrymina@google.com> <20240305020153.2787423-4-almasrymina@google.com>

User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 2024/3/5 10:01, Mina Almasry wrote:
> The check is duplicated in 2 places, factor it out into a common helper.

Reviewed-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>