On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:
> Use the generic variants - the implementation is the same.
> As a nice side-effect fix the following warnings:
>
> cmpdi2.c: warning: no previous prototype for '__cmpdi2' [-Wmissing-prototypes]
> ucmpdi2.c: warning: no previous prototype for '__ucmpdi2' [-Wmissing-prototypes]
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Andreas Larsson <andreas@xxxxxxxxxxx>
> ---
LGTM. You may wish to add:
Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")
but otherwise:
Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>
Tested-by: Maciej W. Rozycki <macro@xxxxxxxxxxx> # build-tested
Maciej
