Re: [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping for a review.

I'd like to get at least the first two patches into the DRM git tree. The PPC patches could later be merged through another tree.

Best regards
Thomas

Am 12.09.23 um 15:48 schrieb Thomas Zimmermann:
Clean up and rename fb_pgprotect() to work without struct file. Then
refactor the implementation for PowerPC. This change has been discussed
at [1] in the context of refactoring fbdev's mmap code.

The first two patches update fbdev and replace fbdev's fb_pgprotect()
with pgprot_framebuffer() on all architectures. The new helper's stream-
lined interface enables more refactoring within fbdev's mmap
implementation.

Patches 3 to 5 adapt PowerPC's internal interfaces to provide
phys_mem_access_prot() that works without struct file. Neither the
architecture code or fbdev helpers need the parameter.

v4:
	* fix commit message (Christophe)
v3:
	* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
v2:
	* reorder patches to simplify merging (Michael)

[1] https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f82c@xxxxxxxx/

Thomas Zimmermann (5):
   fbdev: Avoid file argument in fb_pgprotect()
   fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
   arch/powerpc: Remove trailing whitespaces
   arch/powerpc: Remove file parameter from phys_mem_access_prot code
   arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code

  arch/ia64/include/asm/fb.h                | 15 +++++++--------
  arch/m68k/include/asm/fb.h                | 19 ++++++++++---------
  arch/mips/include/asm/fb.h                | 11 +++++------
  arch/powerpc/include/asm/book3s/pgtable.h | 10 ++++++++--
  arch/powerpc/include/asm/fb.h             | 13 +++++--------
  arch/powerpc/include/asm/machdep.h        | 13 ++++++-------
  arch/powerpc/include/asm/nohash/pgtable.h | 10 ++++++++--
  arch/powerpc/include/asm/pci.h            |  4 +---
  arch/powerpc/kernel/pci-common.c          |  3 +--
  arch/powerpc/mm/mem.c                     |  8 ++++----
  arch/sparc/include/asm/fb.h               | 15 +++++++++------
  arch/x86/include/asm/fb.h                 | 10 ++++++----
  arch/x86/video/fbdev.c                    | 15 ++++++++-------
  drivers/video/fbdev/core/fb_chrdev.c      |  3 ++-
  include/asm-generic/fb.h                  | 12 ++++++------
  15 files changed, 86 insertions(+), 75 deletions(-)


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux