On Fri, 2023-07-14 at 23:57 +0100, Mark Brown wrote: > On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote: > > The x86 Shadow stack feature includes a new type of memory called > > shadow > > stack. This shadow stack memory has some unusual properties, which > > requires > > some core mm changes to function properly. > > This seems to break sparc64_defconfig when applied on top of v6.5- > rc1: > > In file included from /home/broonie/git/bisect/include/linux/mm.h:29, > from /home/broonie/git/bisect/net/core/skbuff.c:40: > /home/broonie/git/bisect/include/linux/pgtable.h: In function > 'pmd_mkwrite': > /home/broonie/git/bisect/include/linux/pgtable.h:528:9: error: > implicit declaration of function 'pmd_mkwrite_novma'; did you mean > 'pte_mkwrite_novma'? [-Werror=implicit-function-declaration] > return pmd_mkwrite_novma(pmd); > ^~~~~~~~~~~~~~~~~ > pte_mkwrite_novma > /home/broonie/git/bisect/include/linux/pgtable.h:528:9: error: > incompatible types when returning type 'int' but 'pmd_t' {aka 'struct > <anonymous>'} was expected > return pmd_mkwrite_novma(pmd); > ^~~~~~~~~~~~~~~~~~~~~~ > > The same issue seems to apply with the version that was in -next > based > on v6.4-rc4 too. The version in your branch is not the same as the version in tip (which had a squashed build fix). I was able to reproduce the build error with your branch. But not with the one in tip rebased on v6.5-rc1. So can you try this version: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/shstk&id=899223d69ce9f338056f4c41ef870d70040fc860