Hi LiuBin. On Fri, Jul 14, 2023 at 08:06:55AM +0200, Sam Ravnborg wrote: > Hi LiuBin > > On Fri, Jul 14, 2023 at 12:56:29PM +0800, liubin001@xxxxxxxxxx wrote: > > Signed-off-by: LiuBin <liubin001@xxxxxxxxxx> > > --- > > arch/sparc/include/asm/floppy_64.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/sparc/include/asm/floppy_64.h > > b/arch/sparc/include/asm/floppy_64.h > > index 070c8c1f5c8f..c4c51f494f25 100644 > > --- a/arch/sparc/include/asm/floppy_64.h > > +++ b/arch/sparc/include/asm/floppy_64.h > > @@ -588,6 +588,7 @@ static unsigned long __init sun_floppy_init(void) > > > > op = of_find_device_by_node(dp); > > if (!op) > > + put_device(op); > > return 0; > > This does not look right as the code will always return 0 now, > independent on the if test. You missed a set of curly braces. Two more notes. Please put the description of the fix in the body of the mail. Right now it is a very long subject - and we try to keep subject shorter than ~70 chars. > > Signed-off-by: LiuBin <liubin001@xxxxxxxxxx> You are expected to sign-off the patch with you name and not a nickname. If LiuBin is indeed you name then sorry and ignore this comment. I look forward to the updated patch. Sam
