On Fri, Jun 16, 2023 at 05:06:18PM +0200, Petr Mladek wrote: > The HAVE_ prefix means that the code could be enabled. Add another > variable for HAVE_HARDLOCKUP_DETECTOR_ARCH without this prefix. > It will be set when it should be built. It will make it compatible > with the other hardlockup detectors. > > The change allows to clean up dependencies of PPC_WATCHDOG > and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc. > > As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies > on arm, x86, powerpc architectures. > > Signed-off-by: Petr Mladek <pmladek@xxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- ... > --- a/include/linux/nmi.h > +++ b/include/linux/nmi.h > @@ -9,7 +9,7 @@ > #include <asm/irq.h> > > /* Arch specific watchdogs might need to share extra watchdog-related APIs. */ > -#if defined(CONFIG_HAVE_HARDLOCKUP_DETECTOR_ARCH) || defined(CONFIG_HARDLOCKUP_DETECTOR_SPARC64) > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_ARCH) || defined(CONFIG_HARDLOCKUP_DETECTOR_SPARC64) This results in: arch/powerpc/platforms/pseries/mobility.c: In function 'pseries_migrate_partition': arch/powerpc/platforms/pseries/mobility.c:753:17: error: implicit declaration of function 'watchdog_hardlockup_set_timeout_pct'; did you mean 'watchdog_hardlockup_stop'? [-Werror=implicit-function-declaration] 753 | watchdog_hardlockup_set_timeout_pct(factor); with ppc64_defconfig -CONFIG_HARDLOCKUP_DETECTOR, because the dummy for watchdog_hardlockup_set_timeout_pct() is still defined in arch/powerpc/include/asm/nmi.h which is no longer included. Guenter > #include <asm/nmi.h> > #endif >
