Hi Ben, On Fri, Jun 16, 2023 at 05:34:49PM +0200, Ben Hutchings wrote: > From: Ben Hutchings <benh@xxxxxxxxxx> > > gas supports several different forms for .section for ELF targets, > including: > .section NAME [, "FLAGS"[, @TYPE[,FLAG_SPECIFIC_ARGUMENTS]]] > and: > .section "NAME"[, #FLAGS...] > > In several places we use a mix of these two forms: > .section NAME, #FLAGS... > > A current development snapshot of binutils (2.40.50.20230611) treats > this mixed syntax as an error. > > Change to consistently use: > .section NAME, "FLAGS" > as is used elsewhere in the kernel. > > Also change the one correct use of: > .section "NAME", #FLAGS > to be consistent with the rest of the kernel. The commit also changes from the solaris compatibility names to the standard gas names. The change surprised me while reading the patch, and I was not happy until I found out that the current flags are compatibility names. So please add this info to the changelog. With that fixed: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> I expect someone else to pick it up. Sam
