Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus powerpc/next powerpc/fixes linus/master v6.3-rc1 next-20230310] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230311-011642 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20230310171416.23356-2-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource() config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230311/202303110550.BLo6P5dS-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/059b4a086017fbf2baacdbe0cc454f569f618ffd git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/PCI-Introduce-pci_dev_for_each_resource/20230311-011642 git checkout 059b4a086017fbf2baacdbe0cc454f569f618ffd # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303110550.BLo6P5dS-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/pnp/quirks.c: In function 'quirk_system_pci_resources': >> drivers/pnp/quirks.c:245:17: error: implicit declaration of function 'pci_dev_for_each_resource' [-Werror=implicit-function-declaration] 245 | pci_dev_for_each_resource(pdev, r, i) { | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/pnp/quirks.c:245:54: error: expected ';' before '{' token 245 | pci_dev_for_each_resource(pdev, r, i) { | ^~ | ; drivers/pnp/quirks.c:233:16: warning: unused variable 'j' [-Wunused-variable] 233 | int i, j; | ^ drivers/pnp/quirks.c:232:26: warning: unused variable 'res' [-Wunused-variable] 232 | struct resource *res, *r; | ^~~ cc1: some warnings being treated as errors vim +/pci_dev_for_each_resource +245 drivers/pnp/quirks.c 228 229 static void quirk_system_pci_resources(struct pnp_dev *dev) 230 { 231 struct pci_dev *pdev = NULL; 232 struct resource *res, *r; 233 int i, j; 234 235 /* 236 * Some BIOSes have PNP motherboard devices with resources that 237 * partially overlap PCI BARs. The PNP system driver claims these 238 * motherboard resources, which prevents the normal PCI driver from 239 * requesting them later. 240 * 241 * This patch disables the PNP resources that conflict with PCI BARs 242 * so they won't be claimed by the PNP system driver. 243 */ 244 for_each_pci_dev(pdev) { > 245 pci_dev_for_each_resource(pdev, r, i) { 246 unsigned long type = resource_type(r); 247 248 if (type != IORESOURCE_IO || type != IORESOURCE_MEM || 249 resource_size(r) == 0) 250 continue; 251 252 if (r->flags & IORESOURCE_UNSET) 253 continue; 254 255 for (j = 0; 256 (res = pnp_get_resource(dev, type, j)); j++) { 257 if (res->start == 0 && res->end == 0) 258 continue; 259 260 /* 261 * If the PNP region doesn't overlap the PCI 262 * region at all, there's no problem. 263 */ 264 if (!resource_overlaps(res, r)) 265 continue; 266 267 /* 268 * If the PNP region completely encloses (or is 269 * at least as large as) the PCI region, that's 270 * also OK. For example, this happens when the 271 * PNP device describes a bridge with PCI 272 * behind it. 273 */ 274 if (res->start <= r->start && res->end >= r->end) 275 continue; 276 277 /* 278 * Otherwise, the PNP region overlaps *part* of 279 * the PCI region, and that might prevent a PCI 280 * driver from requesting its resources. 281 */ 282 dev_warn(&dev->dev, 283 "disabling %pR because it overlaps %s BAR %d %pR\n", 284 res, pci_name(pdev), i, r); 285 res->flags |= IORESOURCE_DISABLED; 286 } 287 } 288 } 289 } 290 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
