On 2/4/23 02:38, Arnd Bergmann wrote: > On Sat, Feb 4, 2023, at 08:47, Randy Dunlap wrote: >> On 1/30/23 05:04, Arnd Bergmann wrote: >> >> Apparently sparc32 does not support PM (arch/sparc/Kconfig): >> >> if SPARC64 >> source "kernel/power/Kconfig" >> endif >> >> so I think that SUN20I_PPU should also depend on !SPARC32. >> Does that make sense? > > I would suggest working around this in arch/sparc/ instead > of every driver that uses 'select PM', perhaps something like > > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -283,7 +283,7 @@ config ARCH_FORCE_MAX_ORDER > This config option is actually maximum order plus one. For example, > a value of 13 means that the largest free memory block is 2^12 pages. > > -if SPARC64 > +if SPARC64 || COMPILE_TEST > source "kernel/power/Kconfig" > endif > That looks good. Thanks. > The issue does not happen anywhere else, as it's fine if > kernel/power/Kconfig is not included at all. I'm also not too > worried about random sparc32 configs since it's pretty much impossible > to build a sparc32 allmodconfig or randconfig, with all the other > bugs that runs into. OK/ack. -- ~Randy
