Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mike Rapoport <rppt@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Fri, 3 Feb 2023 15:31:10 +0100
Cc: Arnd Bergmann <arnd@xxxxxxxx>, Brian Cain <bcain@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Dinh Nguyen <dinguyen@xxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Vineet Gupta <vgupta@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
In-reply-to: <20230129124235.209895-3-rppt@kernel.org>
Organization: Red Hat
References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-3-rppt@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 29.01.23 13:42, Mike Rapoport wrote:

From: "Mike Rapoport (IBM)" <rppt@xxxxxxxxxx>

The MMU variant uses generic definitions of page_to_pfn() and
pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no
good reason.

Include asm-generic/memory_model.h in the common include/asm/page.h and
drop redundant definitions.

Signed-off-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---


Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb

References:
- [PATCH v2 0/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM
  - From: Mike Rapoport
- [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU
  - From: Mike Rapoport

Prev by Date: Re: [PATCH v2 1/4] arm: include asm-generic/memory_model.h from page.h rather than memory.h
Next by Date: Re: [PATCH v2 3/4] mips: drop definition of pfn_valid() for DISCONTIGMEM
Previous by thread: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU
Next by thread: Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [DCCP] [Linux ARM Development] [Linux] [Photo] [Yosemite Help] [Linux ARM Kernel] [Linux SCSI] [Linux x86_64] [Linux Hams]