On Tue, Sep 20, 2022 at 10:57:00AM +0200, Peter Zijlstra wrote: > On Mon, Sep 19, 2022 at 03:19:27PM +0200, Frederic Weisbecker wrote: > > On Mon, Sep 19, 2022 at 11:59:42AM +0200, Peter Zijlstra wrote: > > > cpuidle_state::enter() methods should be IRQ invariant > > > > Got a bit confused with the invariant thing since the first chunck I > > see in this patch is a conversion to an non-traceable local_irq_enable(). > > > > Maybe just add a short mention about that and why? > > Changelog now reads: > > --- > Subject: cpuidle/poll: Ensure IRQ state is invariant > From: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Date: Tue May 31 15:43:32 CEST 2022 > > cpuidle_state::enter() methods should be IRQ invariant. > > Additionally make sure to use raw_local_irq_*() methods since this > cpuidle callback will be called with RCU already disabled. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> Reviewed-by: Frederic Weisbecker <frederic@xxxxxxxxxx> Thanks!
