On Thu, Aug 25, 2022 at 12:15 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > Both alpha https://lore.kernel.org/linux-arch/20220818092059.103884-1-linus.walleij@xxxxxxxxxx/ > & parisc (32 and 64 bits) need this fix also. Yeah I'll try to send something for them too. Also fixed Hexagon. The problem is installing all the cross compilers just to test this stuff.... It's a lot of work. > Is it always safe to do this? I think the arch part is fine, i.e. I don't think it will fix something broken. Then it is the matter of testing the new accessors. That is done by a usecase, in this case, a usecase using a fixed address in 64bit registers write under regmap MMIO. Not sure someone will ever have a usecase for that to test with. The people making use of it need to test it when they use it. As mentioned in the alpha patch, the alternative is to leave regmap-mmio broken for the arch, until someone uses is. It feels wrong to develop generic code for all archs that cannot even compile on all of them, so I prefer to fix it to the point of compiling at least. The generic helpers try their best to be, well generic helpers. Yours, Linus Walleij
